Specify maxTimeMs for MongoDB storage queries #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87bcc78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling for MongoDB storage queries by implementing explicit query timeouts to prevent connection timeouts. The key changes include adding a 40-second timeout limit for MongoDB operations and providing more descriptive error messages when timeouts occur.
Key changes:
- Added maxTimeMS parameter to MongoDB queries to prevent connection socket timeouts
- Implemented specific error handling for query timeouts with new error codes and messages
- Increased the operation timeout from 30 seconds to 40 seconds
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/service-errors/src/errors.ts | Added new DatabaseQueryError class for handling database query-specific errors |
| packages/service-errors/src/codes.ts | Added new error codes PSYNC_S2403 and PSYNC_S2404 for query timeout and failure scenarios |
| modules/module-mongodb-storage/src/storage/implementation/MongoSyncBucketStorage.ts | Added maxTimeMS parameter to MongoDB operations and error handling for bucket data and checksum queries |
| libs/lib-mongodb/src/db/mongo.ts | Increased MONGO_OPERATION_TIMEOUT_MS from 30 seconds to 40 seconds |
| libs/lib-mongodb/src/db/errors.ts | Added mapQueryError function to handle query-specific error mapping |
| .changeset/dull-pumas-punch.md | Added changeset documentation for the MongoDB storage error message improvements |
stevensJourney
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify a limit of 40s for each query, instead of relying on the connection socket timeout. The most common cause is a timeout when computing checksums on buckets with millions of operations. We can often recover by retrying the query - the second attempt is faster since the data would be cached in database memory.
Before:
Now: